Re: [net-next: PATCH v2 5/8] device property: introduce fwnode_dev_node_match

From: Andy Shevchenko
Date: Fri Jul 15 2022 - 15:36:44 EST

On Fri, Jul 15, 2022 at 10:50:09AM +0200, Marcin Wojtas wrote:
> This patch adds a new generic routine fwnode_dev_node_match
> that can be used e.g. as a callback for class_find_device().
> It searches for the struct device corresponding to a
> struct fwnode_handle by iterating over device and
> its parents.

1) misses the word 'parent';
2) located outside of the group of fwnode APIs operating on parents.

I would suggest to rename to fwnode_get_next_parent_node() and place
near to fwnode_get_next_parent_dev() (either before or after, where
it makes more sense).

With Best Regards,
Andy Shevchenko