Re: [PATCH 4/4] kbuild: error out if $(INSTALL_MOD_PATH) contains % or :

[Masahiro Yamada]

On Thu, Jul 14, 2022 at 2:03 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> If the directory pass given to INSTALL_MOD_PATH contains % or :,

A typo.

directory pass  ->  directory path





> the module_install fails.
>
> % is used in pattern rules, and : as the separator of dependencies.
>
> Bail out with a clearer error message.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
>  scripts/Makefile.modinst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index 16a02e9237d3..a4c987c23750 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -18,6 +18,9 @@ INSTALL_MOD_DIR ?= extra
>  dst := $(MODLIB)/$(INSTALL_MOD_DIR)
>  endif
>
> +$(foreach x, % :, $(if $(findstring $x, $(dst)), \
> +       $(error module installation path cannot contain '$x')))
> +
>  suffix-y                               :=
>  suffix-$(CONFIG_MODULE_COMPRESS_GZIP)  := .gz
>  suffix-$(CONFIG_MODULE_COMPRESS_XZ)    := .xz
> --
> 2.34.1
>


-- 
Best Regards
Masahiro Yamada