Re: [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK

From: Linus Walleij
Date: Mon Jul 18 2022 - 05:13:12 EST


On Tue, Jul 12, 2022 at 4:19 AM Li Huafei <lihuafei1@xxxxxxxxxx> wrote:

> This patch converts ARM stacktrace to the generic ARCH_STACKWALK
> implemented by commit 214d8ca6ee85 ("stacktrace: Provide common
> infrastructure").
>
> Signed-off-by: Li Huafei <lihuafei1@xxxxxxxxxx>

Looks good to me:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

What I want to know is if this commit will avoid the problem mentioned
in review of commit 3? I.e. the generic stackwalk code will make sure we are
not running the task on another CPU, so that is why we could remove
that check?

Yours,
Linus Walleij