Re: [PATCH v2 0/5] ARM: Convert to ARCH_STACKWALK

From: Linus Walleij
Date: Mon Jul 18 2022 - 05:14:57 EST


On Wed, Jul 13, 2022 at 1:02 PM Li Huafei <lihuafei1@xxxxxxxxxx> wrote:

> This series mainly updates the ARM stack trace code to use the newer and
> simpler arch_stack_walk() interface. Two issues were fixed before that
> (see patch 1 and 2), as well as allowing stack_trace_save_tsk() to
> trace non-current tasks (see patch 3).
>
> v2:
> - As suggested by Mark, the commit logs for patch 4 and 5 were
> refined for easy review.

I see I reviewed v1 when v2 was already out but think the
comments still stand.

I think you can already add patches 1 & 2 to Russells patch tracker,
they are straight-forward fixes.

Patches 3-5 may need some elaboration but I trust that you have
done some serious testing since you found the snags in
patches 1 & 2.

Yours,
Linus Walleij