Re: [PATCH] pinctrl: Don't allow PINCTRL_AMD to be a module

From: Linus Walleij
Date: Mon Jul 18 2022 - 06:48:42 EST


On Wed, Jul 13, 2022 at 8:00 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:

> It was observed that by allowing pinctrl_amd to be loaded
> later in the boot process that interrupts sent to the GPIO
> controller early in the boot are not serviced. The kernel treats
> these as a spurious IRQ and disables the IRQ.
>
> This problem was exacerbated because it happened on a system with
> an encrypted partition so the kernel object was not accesssible for
> an extended period of time while waiting for a passphrase.
>
> To avoid this situation from occurring, stop allowing pinctrl-amd
> from being built as a module and instead require it to be built-in
> or disabled.
>
> Reported-by: madcatx@xxxxxxxx
> Suggested-by: jwrdegoede@xxxxxxxxxxxxxxxxx
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216230
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Patch applied for fixes!
Excellent root causing.

Yours,
Linus Walleij