Re: [PATCH] pinctrl: qcom: spmi-gpio: make the irqchip immutable

[Robert Marko]

On Mon, 18 Jul 2022 at 11:59, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Sun, Jul 10, 2022 at 1:05 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Fri, Jun 24, 2022 at 9:51 PM Robert Marko <robimarko@xxxxxxxxx> wrote:
> >
> > > Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as
> > > immutable") added a warning to indicate if the gpiolib is altering the
> > > internals of irqchips.
> > >
> > > Following this change the following warning is now observed for the SPMI
> > > PMIC pinctrl driver:
> > > gpio gpiochip1: (200f000.spmi:pmic@0:gpio@c000): not an immutable chip, please consider fixing it!
> > >
> > > Fix this by making the irqchip in the SPMI PMIC pinctrl driver immutable.
> > >
> > > Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> >
> > Patch applied!
>
> Jumping the gun too quick.
>
> Reverted the patch following Marc's feedback.

Thanks for doing this, I was planning to send a revert patch.

Regards,
Robert
>
> Yours,
> Linus Walleij