Re: [PATCH v2 7/8] PCI: qcom: Clean up IP configurations

[Johan Hovold]

On Mon, Jul 18, 2022 at 01:39:32PM +0300, Dmitry Baryshkov wrote:
> On 14/07/2022 10:13, Johan Hovold wrote:
> > The various IP versions have different configurations that are encoded
> > in separate sets of operation callbacks. Currently, there is no need for
> > also maintaining corresponding sets of data parameters, but it is
> > conceivable that these may again be found useful (e.g. to implement
> > minor variations of the operation callbacks).
> > 
> > Rename the default configuration structures after the IP version they
> > apply to so that they can more easily be reused by different SoCs.
> > 
> > Note that SoC specific configurations can be added later if need arises
> > (e.g. cfg_sc8280xp).
> > 
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> 
> 
> If we have nothing left in the qcom_pcie_cfg other than the .ops, what 
> about dropping the qcom_pcie_cfg completely and using the qcom_pcie_ops 
> as match data?

As I mention above I decided to keep the config structures as they can
be used to implement minor variations of the ops.
 
> This patch is nevertheless:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Thanks for reviewing.

Johan