Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used

From: Arnd Bergmann
Date: Mon Jul 18 2022 - 08:42:41 EST


On Mon, Jul 18, 2022 at 1:58 PM Sudip Mukherjee (Codethink)
<sudipm.mukherjee@xxxxxxxxx> wrote:
>
> Hi All,
>
> Not sure if it has been reported, builds of alpha, csky, xtensa, riscv, s390 allmodsconfig
> have failed to build next-20220718 with the error:
>
>
> drivers/pci/controller/dwc/pci-imx6.c:973:13: error: 'imx6_pcie_host_exit' defined but not used [-Werror=unused-function]
> 973 | static void imx6_pcie_host_exit(struct dw_pcie_rp *pp)
> | ^~~~~~~~~~~~~~~~~~~
> drivers/pci/controller/dwc/pci-imx6.c:904:13: error: 'imx6_pcie_stop_link' defined but not used [-Werror=unused-function]
> 904 | static void imx6_pcie_stop_link(struct dw_pcie *pci)
> | ^~~~~~~~~~~~~~~~~~~
>

These are called from inside an "#ifdef CONFIG_PM_SLEEP" section. The best
fix is to remove the #ifdef and replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()
with the new simpler NOIRQ_SYSTEM_SLEEP_PM_OPS().

Arnd