Re: [PATCH v3 2/4] thermal/core: Avoid calling ->get_trip_temp() unnecessarily

[Daniel Lezcano]

On 18/07/2022 06:59, Zhang Rui wrote:
> On Fri, 2022-07-15 at 23:09 +0200, Daniel Lezcano wrote:
> > As the trip temperature is already available when calling the
> > function
> > handle_critical_trips(), pass it as a parameter instead of having
> > this
> > function calling the ops again to retrieve the same data.
> >
> > Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > ---
> >    v3:
> >     - Massaged the patch title and the description
> > ---
> >   drivers/thermal/thermal_core.c | 8 ++------
> >   1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/thermal/thermal_core.c
> > b/drivers/thermal/thermal_core.c
> > index d9f771b15ed8..f66036b3daae 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct
> > thermal_zone_device *tz)
> >   EXPORT_SYMBOL(thermal_zone_device_critical);
> >   
> >   static void handle_critical_trips(struct thermal_zone_device *tz,
> > -                                 int trip, enum thermal_trip_type
> > trip_type)
> > +                                 int trip, int trip_temp, enum
> > thermal_trip_type trip_type)
>
> This indent cleanup belongs to patch 1/4.

It is not an indent cleanup, the 'int trip_temp' is added in the parameters.

> Other than that,
>
> Reviewed-by: Zhang Rui <rui.zhang@xxxxxxxxx>

[ ... ]


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog