Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for mt8188

From: Rob Herring
Date: Mon Jul 18 2022 - 10:12:55 EST


On Mon, 18 Jul 2022 19:38:11 +0800, Hui Liu wrote:
> From: "Hui.Liu" <hui.liu@xxxxxxxxxxxx>
>
> This commit adds mt8188 compatible node in binding document.
>
> Signed-off-by: Hui.Liu <hui.liu@xxxxxxxxxxxx>
> ---
> .../bindings/pinctrl/pinctrl-mt8188.yaml | 306 ++++++++++++++++++
> 1 file changed, 306 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8188.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8188.example.dts:21:18: fatal error: dt-bindings/pinctrl/mt8188-pinfunc.h: No such file or directory
21 | #include <dt-bindings/pinctrl/mt8188-pinfunc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:383: Documentation/devicetree/bindings/pinctrl/pinctrl-mt8188.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1404: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.