Re: [PATCH 2/3] mtd: spi-nor: add support for Quad Page Program to no_sfdp_flags

From: Tudor.Ambarus
Date: Mon Jul 18 2022 - 13:02:28 EST


On 7/12/22 19:38, Sudip Mukherjee wrote:
> [You don't often get email from sudip.mukherjee@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Some flash chips which does not have a SFDP table can support Quad
> Input Page Program. Enable it in hwcaps if defined.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxx>
> ---
> drivers/mtd/spi-nor/core.c | 5 +++++
> drivers/mtd/spi-nor/core.h | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index e5f7691c5bd40..e299fc8fdd3d4 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2375,6 +2375,11 @@ static void spi_nor_no_sfdp_init_params(struct spi_nor *nor)
> spi_nor_set_pp_settings(&params->page_programs[SNOR_CMD_PP_8_8_8_DTR],
> SPINOR_OP_PP, SNOR_PROTO_8_8_8_DTR);
> }
> + if (no_sfdp_flags & SPI_NOR_QUAD_PP) {
> + params->hwcaps.mask |= SNOR_HWCAPS_PP_1_1_4;
> + spi_nor_set_pp_settings(&params->page_programs[SNOR_CMD_PP_1_1_4],
> + SPINOR_OP_PP_1_1_4, SNOR_PROTO_1_1_4);
> + }
>
> /*
> * Sector Erase settings. Sort Erase Types in ascending order, with the
> diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
> index 58fbedc94080f..dde636bdb1a7c 100644
> --- a/drivers/mtd/spi-nor/core.h
> +++ b/drivers/mtd/spi-nor/core.h
> @@ -462,6 +462,7 @@ struct spi_nor_fixups {
> * SPI_NOR_OCTAL_READ: flash supports Octal Read.
> * SPI_NOR_OCTAL_DTR_READ: flash supports octal DTR Read.
> * SPI_NOR_OCTAL_DTR_PP: flash supports Octal DTR Page Program.
> + * SPI_NOR_QUAD_PP: flash supports Quad Input Page Program.

You don't need this flag if your flash supports the 4-byte Address
Instruction Table. Does you flash support it? Can you dump all the
SFDP tables, please?

Thanks,
ta
> *
> * @fixup_flags: flags that indicate support that can be discovered via SFDP
> * ideally, but can not be discovered for this particular flash
> @@ -509,6 +510,7 @@ struct flash_info {
> #define SPI_NOR_OCTAL_READ BIT(5)
> #define SPI_NOR_OCTAL_DTR_READ BIT(6)
> #define SPI_NOR_OCTAL_DTR_PP BIT(7)
> +#define SPI_NOR_QUAD_PP BIT(8)
>
> u8 fixup_flags;
> #define SPI_NOR_4B_OPCODES BIT(0)
> --
> 2.30.2
>