Re: [PATCH V5 1/6] dt-bindings: soc: add i.MX93 SRC

[Rob Herring]

On Mon, Jul 11, 2022 at 02:24:47PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Add bindings for i.MX93 System Reset Controller(SRC). SRC supports
> resets and power gating for mixes.
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>  .../bindings/soc/imx/fsl,imx93-src.yaml       | 95 +++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml
> new file mode 100644
> index 000000000000..5eb22c993d59
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/imx/fsl,imx93-src.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX93 System Reset Controller
> +
> +maintainers:
> +  - Peng Fan <peng.fan@xxxxxxx>
> +
> +description: |
> +  The System Reset Controller (SRC) is responsible for the generation of
> +  all the system reset signals and boot argument latching.
> +
> +  Its main functions are as follows,
> +  - Deals with all global system reset sources from other modules,
> +    and generates global system reset.
> +  - Responsible for power gating of MIXs (Slices) and their memory
> +    low power control.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: fsl,imx93-src
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  ranges: true
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +patternProperties:
> +  "power-domain@[0-9a-f]+$":
> +    $ref: /schemas/power/power-domain.yaml#

No need to reference this as you have to define '#power-domain-cells' 
constraints anyways.

> +
> +    type: object
> +    properties:
> +      compatible:
> +        items:
> +          - const: fsl,imx93-src-slice
> +
> +      '#power-domain-cells':
> +        const: 0
> +
> +      reg:
> +        maxItems: 2

You need to define what each entry is.

> +
> +      clocks:
> +        description: |
> +          A number of phandles to clocks that need to be enabled
> +          during domain power-up sequencing to ensure reset
> +          propagation into devices located inside this power domain.
> +        minItems: 1
> +        maxItems: 5
> +
> +    required:
> +      - compatible
> +      - '#power-domain-cells'
> +      - reg
> +
> +required:
> +  - compatible
> +  - reg
> +  - ranges
> +  - '#address-cells'
> +  - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/imx93-clock.h>
> +
> +    system-controller@44460000 {
> +        compatible = "fsl,imx93-src", "syscon";
> +        reg = <0x44460000 0x10000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;
> +
> +        mediamix: power-domain@0 {
> +            compatible = "fsl,imx93-src-slice";
> +            reg = <0x44462400 0x400>, <0x44465800 0x400>;
> +            #power-domain-cells = <0>;
> +            clocks = <&clk IMX93_CLK_MEDIA_AXI>,
> +                     <&clk IMX93_CLK_MEDIA_APB>;
> +        };
> +    };
> -- 
> 2.25.1
> 
>