Re: [PATCH v3] Add a "-m" option to "perf buildid-list".

[Blake Jones]

Ah yeah of course, sorry about that!


On Mon, Jul 18, 2022 at 12:33 PM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> Em Mon, Jul 18, 2022 at 10:07:32AM -0700, Blake Jones escreveu:
> > Fabulous, thanks!
> >
> > On Mon, Jul 18, 2022 at 7:51 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > wrote:
> > > > > Signed-off-by: Blake Jones <blakejones@xxxxxxxxxx>
> > > >
> > > > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > >
> > > To clarify, b4 found v3 and that was the one applied.
>
> Now fixing this:
>
>   28     5.28 debian:experimental-x-mips    : FAIL gcc version 11.2.0 (Debian 11.2.0-18)
>     builtin-buildid-list.c: In function 'buildid__map_cb':
>     builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                    ~~~~^                  ~~~~~~~~~~
>           |                        |                     |
>           |                        long unsigned int     u64 {aka long long unsigned int}
>           |                    %16llx
>     builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                          ~~~~^                        ~~~~~~~~
>           |                              |                           |
>           |                              long unsigned int           u64 {aka long long unsigned int}
>           |                          %16llx
>     cc1: all warnings being treated as errors
>   29    23.06 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 10.2.1-6) 10.2.1 20210110
>   30     6.08 debian:experimental-x-mipsel  : FAIL gcc version 11.2.0 (Debian 11.2.0-18)
>     builtin-buildid-list.c: In function 'buildid__map_cb':
>     builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                    ~~~~^                  ~~~~~~~~~~
>           |                        |                     |
>           |                        long unsigned int     u64 {aka long long unsigned int}
>           |                    %16llx
>     builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                          ~~~~^                        ~~~~~~~~
>           |                              |                           |
>           |                              long unsigned int           u64 {aka long long unsigned int}
>           |                          %16llx
>     cc1: all warnings being treated as errors
>
>
> These should use PRIx64, etc.
>
> - Arnaldo