Re: [PATCH v5 20/23] dt-bindings: ata: ahci: Add Baikal-T1 AHCI SATA controller DT schema

From: Rob Herring
Date: Mon Jul 18 2022 - 16:34:50 EST


On Wed, 13 Jul 2022 08:29:13 +0300, Serge Semin wrote:
> Baikal-T1 AHCI controller is based on the DWC AHCI SATA IP-core v4.10a
> with the next specific settings: two SATA ports, cascaded CSR access based
> on two clock domains (APB and AXI), selectable source of the reference
> clock (though stable work is currently available from the external source
> only), two reset lanes for the application and SATA ports domains. Other
> than that the device is fully compatible with the generic DWC AHCI SATA
> bindings.
>
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
>
> ---
>
> Changelog v2:
> - Rename 'syscon' property to 'baikal,bt1-syscon'.
> - Drop macro usage from the example node.
>
> Changelog v4:
> - Use the DWC AHCI port properties definition from the DWC AHCI SATA
> common schema. (@Rob)
> - Drop Baikal-T1 syscon reference and implement the clock signal
> source in the framework of the clock controller. (@Rob)
>
> Changelog v5:
> - Drop generic compatible fallback "snps,dwc-ahci". (@Rob)
> - Define SATA-port pattern property to be applicable for two ports
> only.
> - Drop "|" qualifier from the description property.
> ---
> .../bindings/ata/baikal,bt1-ahci.yaml | 115 ++++++++++++++++++
> 1 file changed, 115 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>