Re: [tip: x86/urgent] x86/sgx: Set active memcg prior to shmem allocation
From: Borislav Petkov
Date: Mon Jul 18 2022 - 16:44:30 EST
On Mon, Jul 18, 2022 at 11:52:54AM -0700, Dave Hansen wrote:
> As a further cleanup, it would probably be nice to explicitly document
> that "lookup" and "alloc" also require a subsequent "put".
Certainly. That is not really clear from the sparse comments over it.
> It would also be nice to change sgx_encl_get_backing() to
> __sgx_encl_get_backing() to make it clear that it's an internal thing.
>
> So, I think the _code_ is OK as-is, but it could use some more love.
That makes a lot more sense.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette