Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts

From: Florian Fainelli
Date: Mon Jul 18 2022 - 20:15:33 EST




On 7/16/2022 5:40 AM, Wolfram Sang wrote:
On Wed, Jul 06, 2022 at 10:21:15AM -0700, Florian Fainelli wrote:
When the adapter is registered without interrupts, we would be showing
the following:

# i2cdetect -l
i2c-3 i2c Broadcom STB : I2C adapter

What about switching to pdev->name here? That way you also get the base
address for free to differentiate if there are multiple instances on the
SoC?

I was not sure if we could change the adapter name reported as one could argue this is now ABI, but if we can, then using dev_name() is probably better. You are the maintainer you so know the rules on what is considered stable ABI and what is not :)
--
Florian