Re: [PATCH] net: ethernet: mtk_eth_soc: fix off by one check of ARRAY_SIZE

From: patchwork-bot+netdevbpf
Date: Mon Jul 18 2022 - 23:40:24 EST


Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Sat, 16 Jul 2022 17:46:54 -0400 you wrote:
> In mtk_wed_tx_ring_setup(.., int idx, ..), idx is used as an index here
> struct mtk_wed_ring *ring = &dev->tx_ring[idx];
>
> The bounds of idx are checked here
> BUG_ON(idx > ARRAY_SIZE(dev->tx_ring));
>
> If idx is the size of the array, it will pass this check and overflow.
> So change the check to >= .
>
> [...]

Here is the summary with links:
- net: ethernet: mtk_eth_soc: fix off by one check of ARRAY_SIZE
https://git.kernel.org/netdev/net/c/3696c952da07

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html