Re: [PATCH 2/3] arm64: dts: meson: add S4 Soc clock controller in DT

[Yu Tu]

Hi Krzysztof,
	Thank you for your advice.

On 2022/7/12 17:41, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 08/07/2022 08:27, Yu Tu wrote:
> > Added information about the S4 SOC Clock controller in DT.
> >
> > Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 9 ++++++++-
> >   1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > index ff213618a598..ad2ec26a1f4a 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > @@ -86,7 +86,7 @@ gic: interrupt-controller@fff01000 {
> >   		};
> >   
> >   		apb4: apb4@fe000000 {
> > -			compatible = "simple-bus";
> > +			compatible = "simple-bus", "syscon";
>
> This is not allowed.
> 1. syscon needs also dedicated compatible
> 2. simple-bus with syscon means it is not a simple bus anymore, so nope.
I will correct it.
> >   			reg = <0x0 0xfe000000 0x0 0x480000>;
> >   			#address-cells = <2>;
> >   			#size-cells = <2>;
> > @@ -118,6 +118,13 @@ gpio_intc: interrupt-controller@4080 {
> >   					<10 11 12 13 14 15 16 17 18 19 20 21>;
> >   			};
> >   
> > +			clkc: clock-controller {
> > +				compatible = "amlogic,s4-clkc";
> > +				#clock-cells = <1>;
> > +				clocks = <&xtal>;
> > +				clock-names = "xtal";
> > +			};
> > +
> >   			uart_B: serial@7a000 {
> >   				compatible = "amlogic,meson-s4-uart",
> >   					     "amlogic,meson-ao-uart";
>
>
> Best regards,
> Krzysztof
>
> .