Re: [PATCH 3/3] clk: meson: s4: add s4 SoC clock controller driver

From: Krzysztof Kozlowski
Date: Tue Jul 19 2022 - 02:29:47 EST


On 19/07/2022 08:02, Yu Tu wrote:
> Hi Krzysztof,
> Thank you for your advice.
>
> On 2022/7/12 17:44, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On 08/07/2022 08:27, Yu Tu wrote:
>>> Add the peripheral clock controller found in the s4 SoC family.
>>>
>>> Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx>
>>> ---
>>> MAINTAINERS | 2 +-
>>> drivers/clk/meson/Kconfig | 17 +
>>> drivers/clk/meson/Makefile | 1 +
>>> drivers/clk/meson/s4.c | 4678 ++++++++++++++++++++++++++++++++++++
>>> drivers/clk/meson/s4.h | 156 ++
>>> 5 files changed, 4853 insertions(+), 1 deletion(-)
>>> create mode 100644 drivers/clk/meson/s4.c
>>> create mode 100644 drivers/clk/meson/s4.h
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e4ca46c5c8a1..f116ec0642f2 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1772,7 +1772,7 @@ M: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>>> L: linux-amlogic@xxxxxxxxxxxxxxxxxxx
>>> S: Maintained
>>> F: Documentation/devicetree/bindings/clock/amlogic*
>>> -F: drivers/clk/meson/
>>> +F: drivers/clk/meson/*
>>
>> Why?
> Warning is displayed when using checkpatch. I will correct it.

What warning?

Best regards,
Krzysztof