Re: [PATCH v2] platform/chrome: cros_typec_switch: Add ACPI Kconfig dep

From: Greg KH
Date: Tue Jul 19 2022 - 02:44:19 EST


On Mon, Jul 18, 2022 at 09:27:55PM +0000, Prashant Malani wrote:
> Add the ACPI Kconfig dependency that was missed during the initial
> driver submission. Fixes the following compiler errors:
>
> drivers/platform/chrome/cros_typec_switch.c:93:9: error: call to
> undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not
> support implicit function declarations
> [-Wimplicit-function-declaration]
> ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
>
> drivers/platform/chrome/cros_typec_switch.c:93:35: error: incomplete
> definition of type 'struct acpi_device'
> ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
>
> Fixes: e54369058f3d ("platform/chrome: cros_typec_switch: Add switch driver")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
> ---
>
> Changes since v1:
> - Correct the malformed Reported-by tag. No functional changes.
> (Apologies for the quick respin.)

I already have v1 in my tree, so this isn't going to work, sorry.

greg k-h