Re: [PATCH v6 4/6] scsi: sd: Allow max_sectors be capped at DMA optimal size limit

From: John Garry
Date: Tue Jul 19 2022 - 03:05:38 EST


On 18/07/2022 11:47, Damien Le Moal wrote:
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index a1a2ac09066f..3eaee1f7aaca 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3296,6 +3296,8 @@ static int sd_revalidate_disk(struct gendisk *disk)
(sector_t)BLK_DEF_MAX_SECTORS);
}

Hi Damien,

+ rw_max = min_not_zero(rw_max, sdp->host->opt_sectors);
+
Adding a comment explaining what the cap is would be nice.



Christoph has now applied this (thanks, BTW), so would you like me to follow up with a patch on top with a comment?

Thanks,
John