Re: [PATCH v3 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example

From: Krzysztof Kozlowski
Date: Tue Jul 19 2022 - 03:38:04 EST


On 20/06/2022 18:04, Krzysztof Kozlowski wrote:
> On 07/06/2022 09:52, Krzysztof Kozlowski wrote:
>> The multi-led node defined address/size cells, so it is intended to have
>> children with unit addresses.
>>
>> The second multi-led's reg property defined three LED indexes within one
>> reg item, which is not correct - these are three separate items.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>>
>> ---
>
> Pavel, Jacek,
>
> Any comments on these two patches?

Pavel,

Although previously this was "just" correcting the example, now it is
actually a needed fix because of changes which came later:
https://lore.kernel.org/all/CAL_JsqKHviWcynOu5AYJxtJ5xbQU6cU+r6tHy=ao+Wt4mE1aVQ@xxxxxxxxxxxxxx/

Can you apply it?

Best regards,
Krzysztof