Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

From: Arnd Bergmann
Date: Tue Jul 19 2022 - 03:46:26 EST


On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne <shorne@xxxxxxxxx> wrote:
> On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>>
>> As mentioned before, it would be even better to just remove it
>> entirely from everything except x86, and enclose the four
>> references in an explicit "#ifdef X86_32". The variable declaration
>> only exists because drivers/pci/quirks.c is compiled on all
>> architecture, but the individual quirk is only active based on
>> the PCI device ID of certain early PCI-ISA bridges.
>
>
> Ok, I was thinking of that route but once I saw the pci device IDs I
> wasn't so sure it was limited to x86. I'll go ahead with that approach.

Ok, thanks!

I checked all the PCI IDs yesterday, and I'm fairly sure they are x86
specific. While some related products are general-purpose PCI-ISA
bridges that have shown up on mips or arm boards, the ones listed
here should all be safe.

Arnd