Re: [PATCH V4 net-next] net: marvell: prestera: add phylink support
From: Paolo Abeni
Date: Tue Jul 19 2022 - 05:07:31 EST
On Tue, 2022-07-19 at 08:56 +0000, Oleksandr Mazur wrote:
> > > +
> > > +static void prestera_pcs_an_restart(struct phylink_pcs *pcs)
> > > +{
> > > + /*
> > > + * TODO: add 100basex AN restart support
>
> > Possibly typo above ? s/100basex/1000basex/
>
> Hello Paolo, yes, you're right.
> So, should i wait some time before resubmitting patch again with
> changes - V5 - or it's okay to resubmit new version now?
My personal take: v4 has been out for several days, so it's ok to
submit a new revision now. Others may disagre, but you would be free to
point the finger against me for the suggestion :)
Please additionally have a look to my other comment, regarding
read_lock usage.
Thanks!
Paolo