Re: [PATCH -next 2/5] ASoC: fsl_asrc: force cast the asrc_format type
From: Mark Brown
Date: Tue Jul 19 2022 - 06:17:22 EST
On Tue, Jul 19, 2022 at 10:01:54AM +0000, David Laight wrote:
> From: Shengjiu Wang
> > - ret = of_property_read_u32(np, "fsl,asrc-format", &asrc->asrc_format);
> > + ret = of_property_read_u32(np, "fsl,asrc-format", (u32 *)&asrc->asrc_format);
> Ugg, you really shouldn't need to do that.
> It means that something is badly wrong somewhere.
> Casting pointers to integer types is just asking for a bug.
That's casting one pointer type to another pointer type.
Attachment:
signature.asc
Description: PGP signature