Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board

From: Krzysztof Kozlowski
Date: Tue Jul 19 2022 - 06:18:55 EST


On 19/07/2022 12:15, Francesco Dolcini wrote:
> Hello Krzysztof,
>
> On Tue, Jul 19, 2022 at 12:01:34PM +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> + tca6424: gpio@22 {
>>> + compatible = "ti,tca6424";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_tca6424>;
>>> + reg = <0x22>;
>>
>> compatible, then reg, then all other properties. This applies everywhere.
>
> Is this documented somewhere? It would be easier to enable new people to
> contribute, if it was.

Unfortunately it's not documented. It's a common practice - most
popular, but of course you will find other examples. There is reasoning
behind - compatible is the most important property. Reg is useful to
have at the top as it must match unit address.

> Anyway, I would add to this list status as last, when present,

Yes, this as well in some trees is recommended/enforced although not
documented.

> and I do
> try to order alphabetically all the other properties.
Best regards,
Krzysztof