Re: [RFC Patch net-next 02/10] net: dsa: microchip: add common gigabit set and get function

From: Vladimir Oltean
Date: Tue Jul 19 2022 - 06:37:48 EST


On Tue, Jul 12, 2022 at 09:33:00PM +0530, Arun Ramadoss wrote:
> This patch add helper function for setting and getting the gigabit
> enable for the ksz series switch. KSZ8795 switch has different register
> address compared to all other ksz switches. KSZ8795 series uses the Port
> 5 Interface control 6 Bit 6 for configuring the 1Gbps or 100/10Mbps
> speed selection. All other switches uses the xMII control 1 0xN301
> register Bit6 for gigabit.
> Further, for KSZ8795 & KSZ9893 switches if bit 1 then 1Gbps is chosen
> and if bit 0 then 100/10Mbps is chosen. It is other way around for
> other switches bit 0 is for 1Gbps. So, this patch implements the common
> function for configuring the gigabit set and get capability.
>
> Signed-off-by: Arun Ramadoss <arun.ramadoss@xxxxxxxxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>