Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()

From: Cezary Rojewski
Date: Tue Jul 19 2022 - 07:40:27 EST


On 2022-07-12 4:24 PM, Andy Shevchenko wrote:
On Tue, Jul 12, 2022 at 03:51:04PM +0200, Cezary Rojewski wrote:
On 2022-07-09 10:42 PM, Andy Shevchenko wrote:

...

I still believe that casting blindly is not the way to go. I did explicitly
ask about int vs u32, not int vs unsigned int. Please note that these values
are later passed to the IPC handlers, and this changes the context a bit. If
hw expects u32, then u32 it shall be.

What you can do is probably utilize _Generic() which will reduce the code base
and allow to use the same template for different types.


Writing to let you know that the feedback is not ignored, just my TODO queue is large. Will come back once _Generic() idea is verified on my side or when I have more questions. Thanks once again for your input Andy!


Regards,
Czarek