Re: [net-next PATCH v2 15/15] net: dsa: qca8k: drop unnecessary exposed function and make them static

From: Vladimir Oltean
Date: Tue Jul 19 2022 - 10:11:10 EST


On Tue, Jul 19, 2022 at 02:57:26AM +0200, Christian Marangi wrote:
> Some function were exposed to permit migration to common code. Drop them
> and make them static now that the user are in the same common code.
>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---

Hmm, ideally the last patch that removes a certain function from being
called from qca8k-8xxx.c would also delete its prototype and make it
static in qca8k-common.c. Would that be hard to change?