RE: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder Lake-N and Raptor Lake-P

[Pawnikar, Sumeet R]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Saturday, July 16, 2022 1:19 AM
> To: Pawnikar, Sumeet R <sumeet.r.pawnikar@xxxxxxxxx>
> Cc: rafael@xxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; linux-
> pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder
> Lake-N and Raptor Lake-P
> 
> On Fri, Jul 15, 2022 at 10:22:28PM +0530, Sumeet Pawnikar wrote:
> > Add Alder Lake-N and Raptor Lake-P to the list of processor models for
> > which Power Limit4 is supported by the Intel RAPL driver.
> >
> > Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@xxxxxxxxx>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> 
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> You may not convert people's review into a tag without their consent.
> But taking into account this is trivial patch, it's fine. Just follow the rules next
> time.
> 
Thanks for your time to review this. 
Got your point. I'll follow this rule going forward. 

> Also, where is v1? What are the differences to it?
> 
Sorry for this confusion. Actually this is the v2 version in the internal review,
I forgot to remove the v2 prefix when submitting externally. 
I'll resend this patch removing v2. 

Thanks,
Sumeet. 

> > ---
> >  drivers/powercap/intel_rapl_msr.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/powercap/intel_rapl_msr.c
> > b/drivers/powercap/intel_rapl_msr.c
> > index 9d23984d8931..bc6adda58883 100644
> > --- a/drivers/powercap/intel_rapl_msr.c
> > +++ b/drivers/powercap/intel_rapl_msr.c
> > @@ -140,7 +140,9 @@ static const struct x86_cpu_id pl4_support_ids[] = {
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_TIGERLAKE_L,
> X86_FEATURE_ANY },
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE,
> X86_FEATURE_ANY },
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_L,
> X86_FEATURE_ANY },
> > +	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_N,
> X86_FEATURE_ANY },
> >  	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE,
> X86_FEATURE_ANY },
> > +	{ X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE_P,
> X86_FEATURE_ANY },
> >  	{}
> >  };
> 
> --
> With Best Regards,
> Andy Shevchenko
>