Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board

[Krzysztof Kozlowski]

On 19/07/2022 18:37, Martyn Welch wrote:
> On Tue, 2022-07-19 at 12:01 +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> Add device trees for one of a number of MSCs variants of the SM2S-
>>> IMX8PLUS
>>> system on module along with the compatible SM2S-SK-AL-EP1 carrier
>>> board.
>>> As the name suggests, this family of SoMs use the NXP i.MX8MP SoC
>>> and
>>> provide the SMARC module interface.
>>>
>>> Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
>>
>> Use subject prefix matching subsystem. I expect other folks in
>> Collabora
>> help you in that, so you do not need our advices for such trivial
>> stuff. :)
>>
> 
> Hi Krzysztof,
> 
> Thanks for the review.
> 
> I picked that based on the last 20-30 commits under
> arch/arm64/boot/dts/. Would you prefer something starting "arm64: dts:
> freescale: "? I see that "arm64: dts: imx8mp: " is typically being used
> for changes to the more generic imx8mp device trees...

git log --oneline --
gives you three popular answers (where first seems the most popular):
arm64: dts: board-name:
arm64: dts: freescale:
arm64: dts: freescale: board-name:

> 
>>> +       extcon_usb0: extcon_usb0 {
>>
>> No underscores, extcon is Linux term, so use node name describing
>> device.
>>
> 
> I note that the device binding file lists an example using
> "extcon_usb1". I also note that existing users seem to broadly use a
> variation of "extcon-XXXX", would "extcon-usb0" be acceptable in this
> case?

It still uses extcon, so a Linux driver name not hardware, but I don't
have other idea, at the moment.

Best regards,
Krzysztof