Re: [PATCH 07/12] KVM: X86/MMU: Remove the useless struct mmu_page_path

From: Sean Christopherson
Date: Tue Jul 19 2022 - 16:15:27 EST


Nit, s/useless/now-unused, or "no longer used". I associate "useless" in shortlogs
as "this <xyz> is pointless and always has been pointless", whereas "now-unused"
is likely to be interpreted as "remove <xyz> as it's no longer used after recent
changes".

Alternatively, can this patch be squashed with the patch that removes
mmu_pages_clear_parents()? Yeah, it'll be a (much?) larger patch, but leaving
dead code behind is arguably worse.

On Sun, Jun 05, 2022, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@xxxxxxxxxxxx>
>
> struct mmu_page_path is set and updated but never used since
> mmu_pages_clear_parents() is removed.
>
> Remove it.
>
> Signed-off-by: Lai Jiangshan <jiangshan.ljs@xxxxxxxxxxxx>
> ---