Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used

From: Arnd Bergmann
Date: Tue Jul 19 2022 - 17:17:05 EST


On Tue, Jul 19, 2022 at 11:04 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> commit 0e4daeaa52ca ("PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()")
> Author: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Date: Tue Jul 19 15:50:18 2022 -0500
>
> PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()
>
> Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with NOIRQ_SYSTEM_SLEEP_PM_OPS(),
> which has the advantage that the compiler always sees the PM callbacks as
> referenced, so they don't need to be wrapped with "#ifdef CONFIG_PM_SLEEP"
> or tagged with "__maybe_unused" to avoid "defined but not used" warnings.
>
> See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones").
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>