Re: [PATCH v3 1/4] dt-bindings: leds: qcom-lpg: Add compatible for PM660L LPG block

From: Marijn Suijten
Date: Tue Jul 19 2022 - 17:23:45 EST


On 2022-07-19 02:35:50, Bhupesh Sharma wrote:
>
> On 5/12/22 12:37 AM, Marijn Suijten wrote:
> > Document the availability of an LPG configuration for the PM660L PMIC in
> > the Qualcomm Light Pulse Generator driver.
> >
> > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > index 409a4c7298e1..cd02811583ec 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > @@ -17,6 +17,7 @@ description: >
> > properties:
> > compatible:
> > enum:
> > + - qcom,pm660l-lpg
> > - qcom,pm8150b-lpg
> > - qcom,pm8150l-lpg
> > - qcom,pm8350c-pwm
>
>
> This patch seems to have slipped through the cracks, as running a
>
> 'make dtbs_check' currently on linux-next tip causes the following issue:
>
> arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dtb:0:0:
> /soc/spmi@800f000/pmic@3/lpg@b100:
>   failed to match any schema with compatible: ['qcom,pm660l-lpg']
>
> If it helps:
>
> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>

Thanks. It is not only this patch but also the accompanying driver
change; both have to go through the leds tree. Bjorn already picked the
DTS patches as they have to go through the Qcom DTS tree.

I've resent a rebased v4, solving some context markers jumping to
different lines and dropping applied patches to hopefully make it clear
that only these are outstanding. Feel free to submit your Reviewed-by:
to the driver patch as well in hopes of making it in with the DTS
changes for 5.20:

https://lore.kernel.org/linux-arm-msm/20220719211848.1653920-1-marijn.suijten@xxxxxxxxxxxxxx/T/#t

Thanks!
- Marijn