Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

From: Bart Van Assche
Date: Tue Jul 19 2022 - 19:07:25 EST


On 7/19/22 00:01, Can Guo wrote:
Adds MCQ support to UFS driver.

The description of this patch is too short. It should be explained how the UFSHCI queues are made visible to the block layer. It should also be explained which roles are assigned to queues and how (HCTX_TYPE_*). How the MAXQ configuration register is handled should also be explained.

The host lock is obtained in multiple UFSHCI 3.0 code paths. Information about the role of the host lock in MCQ code should be provided.

Thanks,

Bart.