Re: [PATCH v4 00/34] Printbufs - new data structure for building strings

[Kent Overstreet]

On 7/19/22 20:05, Steven Rostedt wrote:
> On Tue, 19 Jul 2022 19:43:46 -0400
> Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote:
>
> > On 7/19/22 19:15, Steven Rostedt wrote:
> > > On Sun, 19 Jun 2022 20:41:59 -0400
> > > Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote:
> > >    
> > > > Core idea: Wouldn't it be nice if we had a common data structure and calling
> > > > convention for outputting strings?
> > >
> > > Because seq_buf gives us this already, the cover letter really just needs
> > > to state exactly what the benefit is to replace seq_buf with printbuf (and
> > > why seq_buf can not be simply extended to do some extra features).
> >
> >    - seq_buf has the wrong semantics on overflow for what vsnprintf needs.
>
> More specific please.

Steve, look at the man page for snprintf if you don't see what I mean. 
This discussion has become entirely too tedious, and your _only_ 
contribution to the discussion on pretty-printers has been "why isn't 
this using this thing I made?".

You haven't been contributing to the discussion, you haven't been 
helping figure out what the APIs, helpers, data structures should look 
like, IOW _actually_ building something that could serve as a low level 
string formatting library.

I get that you're busy - but look, we all are, and this patch series has 
already been set back what, a month and a half while I was waiting on you.

I've got the tests now, I'll CC you when v5 is posted.