Re: [PATCH 00/17] nolibc: add preliminary self tests

From: Willy Tarreau
Date: Tue Jul 19 2022 - 23:26:57 EST


On Tue, Jul 19, 2022 at 03:49:47PM -0700, Paul E. McKenney wrote:
> But I do get "71 test(s) passed." when running on x86. I will let you
> decide whether that constitutes all being well or indicates a bug in
> the tests. ;-)

Technically speaking both are possible, but one is more likely :-)

> > The program can automatically modulate QEMU's return value on x86 when
> > QEMU is run with the appropriate options, but for now I'm not using it
> > as I felt like it didn't bring much value, and the output is more useful.
> > That's debatable, and maybe some might want to use it in bisect scripts
> > for example. It's too early to say IMHO.
>
> For the moment, grepping the output works. And perhaps indefinitely.

That's my intuition as well, given that there will always be a bit of
scripting around that anyway.

> This series is now on the -rcu tree's "dev" branch.

Thank you!

> I got two almost
> identical copies of patch 7, so I took the later of the two. Please let
> me know if I guessed wrong.

Oh you're right, I'm sorry about that. I adjusted one commit message late
and failed to erase the previous one from the directory. In either case
we really don't care but I thought that the one mentioning "stdlib" which
is the term used in the test was better.

Thanks again for your time,
Willy