Re: [PATCH v2 3/4] dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject

From: Michal Simek
Date: Wed Jul 20 2022 - 04:26:56 EST




On 7/20/22 08:15, Krzysztof Kozlowski wrote:
On 20/07/2022 08:00, Appana Durga Kedareswara rao wrote:
From: Appana Durga Kedareswara rao <appana.durga.rao@xxxxxxxxxx>

The Triple Modular Redundancy(TMR) Inject core provides functional fault
injection by changing selected MicroBlaze instructions, which provides the
possibility to verify that the TMR subsystem error detection and fault
recovery logic is working properly.

Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@xxxxxxx>
Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xxxxxxxxxx>

Keep only one SoB.

nit: First of all it is from xilinx.com that's why xilinx.com should be the first.

Just for my understanding about guidance here.
Code was developed by Xilinx before acquisition with AMD. And because it was picked from vendor tree origin xilinx.com was there to keep origin author there. And upstreaming is done by new company. I can't see nothing wrong on keeping both emails there but that's why my opinion. Definitely not a problem to remove one of them but wanted to make sure that we do it properly for all our submissions.

Thanks,
Michal