Re: [PATCH 1/2] ARM: at91: add sam_linux_is_in_normal_world() function

[Claudiu.Beznea]

On 04.07.2022 20:34, clement.leger@xxxxxxxxxxx wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Le 2022-07-04 08:19, Claudiu.Beznea@xxxxxxxxxxxxx a écrit :
>> Hi, Clement,
>>
>> On 06.06.2022 17:57, Clément Léger wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>>> the content is safe
>>>
>>> Add sam_linux_is_in_normal_world() which allows to know if Linux is
>>> running in the normal world or not. This function is used by code
>>> which needs to differentiate the world in which Linux is running.
>>>
>>> Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx>
>>> ---
>>>  arch/arm/mach-at91/sam_secure.c | 6 ++++++
>>>  arch/arm/mach-at91/sam_secure.h | 1 +
>>>  2 files changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-at91/sam_secure.c
>>> b/arch/arm/mach-at91/sam_secure.c
>>> index 2a01f7a7d13f..1ec8c8b9d119 100644
>>> --- a/arch/arm/mach-at91/sam_secure.c
>>> +++ b/arch/arm/mach-at91/sam_secure.c
>>> @@ -27,6 +27,12 @@ struct arm_smccc_res sam_smccc_call(u32 fn, u32
>>> arg0, u32 arg1)
>>>         return res;
>>>  }
>>>
>>> +bool sam_linux_is_in_normal_world(void)
>>> +{
>>> +       /* If optee has been detected, then we are running in normal
>>> world */
>>
>> In case optee hasn't been detected don't we run also in normal world?
>> What I want to say is that maybe you can change the function name to
>> something like sam_linux_is_optee_available().
> 
> I would say it depends on the bootloader configuration, but Linux can
> run
> in secure world also. It would not change a lot of thing though.
> However, you are right sam_linux_optee_is_available() seems easier to
> understand ;)

Changed the name and applied it to at91-soc, thanks!

> 
> Clément