Re: [PATCH 1/2] dt-bindings: net: cdns,macb: Add versal compatible string

From: Krzysztof Kozlowski
Date: Wed Jul 20 2022 - 07:46:00 EST


On 20/07/2022 13:36, Katakam, Harini wrote:
>>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> index 9c92156869b2..1e9f49bb8249 100644
>>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> @@ -22,6 +22,7 @@ properties:
>>> - enum:
>>> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
>>> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
>>> + - cdns,versal-gem # Xilinx Versal
>>
>> Not really ordered by name. Why adding to the end?
>
> Thanks for the review. It is just based on the order in which device
> families from Xilinx were released. I can alphabetize if that's preferred.

Yes, it's the easiest way to avoid conflicts.

Best regards,
Krzysztof