Re: [PATCH v4 0/4] s390/crash: support multi-segment iterators

From: Alexander Egorenkov
Date: Wed Jul 20 2022 - 08:15:28 EST


HI Alexander,

Alexander Gordeev <agordeev@xxxxxxxxxxxxx> writes:

> Hi Matthew et al,
>
> This series completes 5d8de293c224 ("vmcore: convert copy_oldmem_page()
> to take an iov_iter") for s390.
>
> Changes since v3:
> - concurrent access to HSA and oldmem swap buffers protected;
>
> Changes since v2:
> - Matthew Wilcox suggestion is adopted, with that...
> - copy_to_iter() is used instead of custom implementation;
>
> Changes since v1:
> - number of bytes left to copy on fail fixed;
>
> Thanks!
>
>
> Alexander Gordeev (4):
> s390/zcore: fix race when reading from hardware system area
> s390/crash: move copy_to_user_real() to crash_dump.c
> s390/crash: use static swap buffer for copy_to_user_real()
> s390/crash: support multi-segment iterators
>
> arch/s390/include/asm/os_info.h | 17 ++++-
> arch/s390/include/asm/sclp.h | 4 +-
> arch/s390/include/asm/uaccess.h | 1 -
> arch/s390/kernel/crash_dump.c | 114 ++++++++------------------------
> arch/s390/mm/maccess.c | 26 --------
> drivers/s390/char/zcore.c | 55 ++++++++-------
> 6 files changed, 71 insertions(+), 146 deletions(-)
>
> --
> 2.34.1

all our kdump + makedumpfile (with CP as core collector as well) work
with these patches applied.

Tested on LPAR and zVM.
With and w/o KASAN.

Tested-by: Alexander Egorenkov <egorenar@xxxxxxxxxxxxx>

Regards
Alex