Re: linux-next: build failure after merge of the asm-generic tree

[Arnd Bergmann]

On Wed, Jul 20, 2022 at 2:36 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi all,
>
> After merging the asm-generic tree, today's linux-next build (arm64
> defconfig) failed like this:
>
> drivers/char/mem.c: In function 'page_is_allowed':
> drivers/char/mem.c:66:16: error: implicit declaration of function 'devmem_is_allowed'; did you mean 'page_is_allowed'? [-Werror=implicit-function-declaration]
>    66 |         return devmem_is_allowed(pfn);
>       |                ^~~~~~~~~~~~~~~~~
>       |                page_is_allowed
> cc1: some warnings being treated as errors
>
> Caused by commit
>
>   cdfde8f61a00 ("asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED")
>
> arm64 does not have a separate declaration of devmem_is_allowed() and
> was using the asm-generic one by accident ... some other architectures
> may be in the same boat.
>
> I have reverted that commit for today.

My mistake. I was already aware that the patch was broken, and Lukas said he
wanted to send an updated version. Unfortunately I picked up the old version
of my asm-generic-fixes branch as I applied a different patch. I've reworked
the branch to take this one out again now.

        Arnd