Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

[Doug Anderson]

Hi,

On Wed, Jul 20, 2022 at 12:37 AM Yunlong Jia
<yunlong.jia@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>
> Signed-off-by: Yunlong Jia <yunlong.jia@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> index 764c451c1a857..767cb7450c0d8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> @@ -14,7 +14,7 @@
>
>  / {
>         model = "Google Pazquel (Parade,LTE)";
> -       compatible = "google,pazquel-sku4", "qcom,sc7180";
> +       compatible = "google,pazquel-sku6", "google,pazquel-sku4", "qcom,sc7180";

Now this doesn't match the bindings. The bindings list 4 first and
then 6. You are listing 6 first then 4. The order doesn't really
matter, but the two places need to match.

As Krzysztof says, you should be incrementing the version of your
patches, adding some history, and you should also put the two patches
in one series.

I believe you're using patman, so something like this and have _both_
changes applied and send them out.

In patch #1 (the bindings):

Series-changes: 3
- Bindings and dts in the same series.

In patch #2 (the dts):

Series-version: 3

Series-changes: 2
- Put sku6 before sku4

Series-changes: 3
- Bindings and dts in the same series.

-Doug