Re: [PATCH v2 3/3] arm64: dts: sm2s-imx8mp: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board

From: Krzysztof Kozlowski
Date: Wed Jul 20 2022 - 13:11:37 EST


On 20/07/2022 17:00, Martyn Welch wrote:
> Add device trees for one of a number of MSCs variants of the SM2S-IMX8PLUS
> system on module along with the compatible SM2S-SK-AL-EP1 carrier board.
> As the name suggests, this family of SoMs use the NXP i.MX8MP SoC and
> provide the SMARC module interface.
>
> Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>> ---
>
> Changes in v2
> - Added compatibles
> - Removed underscores from node names
> - Make node names more generic
> - Reorder properties
> - Fix issues found by dtbs_check in these files
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++
> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 52 ++

Subject prefix is somehow reversed. sm2s is not a SoC.

arm64: dts: imx8mp-msc-sm2s:

Rest looks ok, except the discussion about actual company prefix.

Best regards,
Krzysztof