Re: [PATCH v10 5/8] mm/demotion: Build demotion targets based on explicit memory tiers
From: kernel test robot
Date: Wed Jul 20 2022 - 20:04:24 EST
Hi "Aneesh,
I love your patch! Yet something to improve:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Aneesh-Kumar-K-V/mm-demotion-Memory-tiers-and-demotion/20220720-110356
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: arm64-randconfig-r025-20220718 (https://download.01.org/0day-ci/archive/20220721/202207210723.HeaXhM1j-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b5fc1c467550e9f07b8f128b554a7d68e13628ff
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Aneesh-Kumar-K-V/mm-demotion-Memory-tiers-and-demotion/20220720-110356
git checkout b5fc1c467550e9f07b8f128b554a7d68e13628ff
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
mm/memory-tiers.c: In function 'migrate_on_reclaim_init':
>> mm/memory-tiers.c:349:17: error: 'node_demotion' undeclared (first use in this function)
349 | node_demotion = kcalloc(MAX_NUMNODES, sizeof(struct demotion_nodes),
| ^~~~~~~~~~~~~
mm/memory-tiers.c:349:17: note: each undeclared identifier is reported only once for each function it appears in
vim +/node_demotion +349 mm/memory-tiers.c
345
346 static void __init migrate_on_reclaim_init(void)
347 {
348 if (IS_ENABLED(CONFIG_MIGRATION)) {
> 349 node_demotion = kcalloc(MAX_NUMNODES, sizeof(struct demotion_nodes),
350 GFP_KERNEL);
351 WARN_ON(!node_demotion);
352 }
353 hotplug_memory_notifier(migrate_on_reclaim_callback, MEMTIER_HOTPLUG_PRIO);
354 }
355
--
0-DAY CI Kernel Test Service
https://01.org/lkp