[linux-stable-rc:linux-5.10.y 3585/7104] drivers/gpu/drm/i915/gt/intel_gt.c:732:2: error: format string is not a string literal (potentially insecure)
From: kernel test robot
Date: Wed Jul 20 2022 - 23:15:37 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
head: 024476cf51e88407e84736ff298652322459beb5
commit: 6a6acf927895c38bdd9f3cd76b8dbfc25ac03e88 [3585/7104] drm/i915: Flush TLBs before releasing backing store
config: i386-randconfig-a002-20220718 (https://download.01.org/0day-ci/archive/20220721/202207211126.LnCtB2kQ-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project dd5635541cd7bbd62cd59b6694dfb759b6e9a0d8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=6a6acf927895c38bdd9f3cd76b8dbfc25ac03e88
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-5.10.y
git checkout 6a6acf927895c38bdd9f3cd76b8dbfc25ac03e88
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gt/intel_gt.c:732:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
GEM_TRACE("\n");
^~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/intel_gt.c:732:2: note: treat the string as an argument to avoid this
drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE'
#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
^
include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk'
do_trace_printk(fmt, ##__VA_ARGS__); \
^
include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk'
__trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \
^
1 error generated.
vim +732 drivers/gpu/drm/i915/gt/intel_gt.c
693
694 void intel_gt_invalidate_tlbs(struct intel_gt *gt)
695 {
696 static const i915_reg_t gen8_regs[] = {
697 [RENDER_CLASS] = GEN8_RTCR,
698 [VIDEO_DECODE_CLASS] = GEN8_M1TCR, /* , GEN8_M2TCR */
699 [VIDEO_ENHANCEMENT_CLASS] = GEN8_VTCR,
700 [COPY_ENGINE_CLASS] = GEN8_BTCR,
701 };
702 static const i915_reg_t gen12_regs[] = {
703 [RENDER_CLASS] = GEN12_GFX_TLB_INV_CR,
704 [VIDEO_DECODE_CLASS] = GEN12_VD_TLB_INV_CR,
705 [VIDEO_ENHANCEMENT_CLASS] = GEN12_VE_TLB_INV_CR,
706 [COPY_ENGINE_CLASS] = GEN12_BLT_TLB_INV_CR,
707 };
708 struct drm_i915_private *i915 = gt->i915;
709 struct intel_uncore *uncore = gt->uncore;
710 struct intel_engine_cs *engine;
711 enum intel_engine_id id;
712 const i915_reg_t *regs;
713 unsigned int num = 0;
714
715 if (I915_SELFTEST_ONLY(gt->awake == -ENODEV))
716 return;
717
718 if (INTEL_GEN(i915) == 12) {
719 regs = gen12_regs;
720 num = ARRAY_SIZE(gen12_regs);
721 } else if (INTEL_GEN(i915) >= 8 && INTEL_GEN(i915) <= 11) {
722 regs = gen8_regs;
723 num = ARRAY_SIZE(gen8_regs);
724 } else if (INTEL_GEN(i915) < 8) {
725 return;
726 }
727
728 if (drm_WARN_ONCE(&i915->drm, !num,
729 "Platform does not implement TLB invalidation!"))
730 return;
731
> 732 GEM_TRACE("\n");
--
0-DAY CI Kernel Test Service
https://01.org/lkp