Re: [RFC PATCH 1/4] clk: Use clk_core_unlink_consumer on __clk_put

From: Abel Vesa
Date: Thu Jul 21 2022 - 04:17:59 EST


On 22-07-07 13:03:06, Abel Vesa wrote:
> For consistency, use clk_core_unlink_consumer rather then hlist_del
> directly, on __clk_put. Prepare lock is already acquired at that point.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>

Gentle ping.

> ---
> drivers/clk/clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 7fc191c15507..e1d8245866b1 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -4347,7 +4347,7 @@ void __clk_put(struct clk *clk)
> clk->exclusive_count = 0;
> }
>
> - hlist_del(&clk->clks_node);
> + clk_core_unlink_consumer(clk);
> if (clk->min_rate > clk->core->req_rate ||
> clk->max_rate < clk->core->req_rate)
> clk_core_set_rate_nolock(clk->core, clk->core->req_rate);
> --
> 2.34.3
>