Re: [PATCH 5/6] mtd: spi-nor: add generic flash driver

[Michael Walle]

Hi,

> > +
> > +	/* Fallback to a generic flash described only by its SFDP data. */
> > +	if (!info) {
> > +		ret = spi_nor_check_sfdp_signature(nor);
> > +		if (!ret)
> > +			info = &spi_nor_generic_flash;
> > +	}
>
> May be this can be combined as
>
>  	if (!info && (!spi_nor_check_sfdp_signature(nor)))
> 		info = &spi_nor_generic_flash;

While this is the behavior, I don't like (1) calling functions
in the condition and (2) rely on the && and || semantics, i.e.
to just call the second part if the first is true/false.

-michael