Re: [PATCH] HID: nintendo: Add missing array termination

From: Jiri Kosina
Date: Thu Jul 21 2022 - 07:48:50 EST


On Tue, 12 Jul 2022, Dmitry Torokhov wrote:

> On Tue, Jul 12, 2022 at 03:17:05PM -0700, Guenter Roeck wrote:
> > joycon_dpad_inputs_jc[] is unterminated. This may result in odd warnings
> > such as
> >
> > input: input_set_capability: invalid code 3077588140 for type 1
> >
> > or in kernel crashes in nintendo_hid_probe(). Terminate the array to fix
> > the problem.
> >
> > Fixes: 2af16c1f846bd ("HID: nintendo: add nintendo switch controller driver")
> > Cc: Daniel J. Ogorchock <djogorchock@xxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> I'd recommend tagging stable on this one.

I did so and applied, thanks.

--
Jiri Kosina
SUSE Labs