RE: [PATCH net-next v3 33/47] net: fman: Clean up error handling

[Camelia Alexandra Groza]

> -----Original Message-----
> From: Sean Anderson <sean.anderson@xxxxxxxx>
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
> netdev@xxxxxxxxxxxxxxx
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell
> King <linux@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Sean Anderson
> <sean.anderson@xxxxxxxx>
> Subject: [PATCH net-next v3 33/47] net: fman: Clean up error handling
> 
> This removes the _return label, since something like
> 
> 	err = -EFOO;
> 	goto _return;
> 
> can be replaced by the briefer
> 
> 	return -EFOO;
> 
> Additionally, this skips going to _return_of_node_put when dev_node has
> already been put (preventing a double put).
> 
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>

Acked-by: Camelia Groza <camelia.groza@xxxxxxx>